KIP-455: Implement alterPartitionReassignments/listPartitionReassignments admin methods #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fixtures for alterPartitionReassigments Update request and response for alterPartitionReassignments to take into account TAG_BUFFERS, COMPACT_ARRAYS, and COMPACT Strings
jonathanhaviv
changed the title
Nevon
requested changes
Jul 20, 2022
There was a problem hiding this comment.
I'm afraid I haven't had time to go through this really thoroughly yet, as I'm busy with my real job, but there are a couple of things that will need to be looked at. Most importantly the handling of the tagged fields in the response header, since the current implementation won't work if we receive any tagged field, even though the API version indicates that we support them.
src/protocol/requests/alterPartitionReassignments/v0/request.spec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Tommy Brunn <tommy.brunn@gmail.com>
Nevon
approved these changes
Jul 25, 2022
Nevon
requested changes
Jul 25, 2022
Nevon
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the protocols and methods for alterPartitionReassignments and listPartitionReassignments referenced in #1181. There are also a few updates to the encoder and decoder for working with the types added by KIP-482:
One note on tagged fields. Requests and responses with tagged fields have them in two places:
The implication of this is that if there are no tagged fields a zero byte needs to be written/read in multiple places depending on the rest of the request/response.
Hope that helps with how to handle any protocols that use the tagged fields or compact types.