Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent idempotent producer error handling fixes #1172

Merged
merged 6 commits into from Feb 9, 2022
Merged

Concurrent idempotent producer error handling fixes #1172

merged 6 commits into from Feb 9, 2022

Conversation

t-d-d
Copy link
Contributor

@t-d-d t-d-d commented Aug 14, 2021

This is on top of #1050 . Added:

  • a lock per broker so that the broker request and sequence number handling (including reverting on an error) is serialised
  • used sharedPromise on a few cluster functions to stop multiple concurrent calls

@t-d-d
Use sharedPromise for some cluster functions.
3a4caa5 
Use mutex lock for idempotent producer critical section
@t-d-d t-d-d mentioned this pull request Aug 14, 2021
Closed
aikoven
aikoven reviewed Sep 2, 2021
View reviewed changes
src/cluster/index.js Outdated Show resolved Hide resolved
aikoven referenced this pull request in aikoven/kafkajs Jan 16, 2022
1.15.0-fork.4
d08db4f
@Nevon Nevon merged commit 1876abc into tulios:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikoven aikoven aikoven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-d-d @aikoven @Nevon