Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuist with dependency cycle failed to generate #6273

Closed
vvisionnn opened this issue May 11, 2024 · 6 comments
Closed

Tuist with dependency cycle failed to generate #6273

vvisionnn opened this issue May 11, 2024 · 6 comments
Labels
type:bug Something isn't working

Comments

@vvisionnn
Copy link

What happened?

the official example in fixture folder,
I think this is a example for handle with dependency cycle, but with the latest tuist version 4.12.1, failed to generate
raised an error

Found circular dependency between targets: 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkA:FrameworkA -> 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkB:FrameworkB -> 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkA:FrameworkA

How do we reproduce it?

  1. clone tuist repo (this repo)
  2. walk into fixture/ios_workspace_with_dependency_cycle folder
  3. run tuist generate
  4. you will find the same error with what I reported

Error log

Found circular dependency between targets: 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkA:FrameworkA -> 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkB:FrameworkB -> 
/Users/<username>/<folder>/tuist/fixtures/ios_workspace_with_dependency_cycle/Frameworks/FrameworkA:FrameworkA

macOS version

14.4.1

Tuist version

4.12.1

Xcode version

15.3 Release

@vvisionnn vvisionnn added the type:bug Something isn't working label May 11, 2024
@vvisionnn
Copy link
Author

while I cannot find this example in the official tuist 4 doc, but it still exist in tuist 3 doc, just want to make sure is this an error/bug or you guys just dropped this feature

@vvisionnn
Copy link
Author

@pepicrft
Copy link
Contributor

while I cannot find this example in the official tuist 4 doc, but it still exist in tuist 3 doc, just want to make sure is this an error/bug or you guys just dropped this feature

The feature wasn't dropped in Tuist 4. We have the tool in place with plenty of unit tests testing various scenarios.

Based on the logs that you shared, the feature seems to be working fine. What makes you think otherwise?

@vvisionnn
Copy link
Author

oh I know, so the example showing there does not means that we CAN create a cycle dependency structure but means tuist can detect cycle dependency and report it, am I right?

@vvisionnn
Copy link
Author

@pepicrft I think this shouldn't be a problem if you can make sure my last reply is correct, I will close this issue for now

@fortmarek
Copy link
Member

oh I know, so the example showing there does not means that we CAN create a cycle dependency structure but means tuist can detect cycle dependency and report it, am I right?

Yes, that's correct 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants