Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuist doesn't work with KSCrash #6145

Closed
kapitoshka438 opened this issue Apr 2, 2024 · 2 comments · Fixed by #6260
Closed

Tuist doesn't work with KSCrash #6145

kapitoshka438 opened this issue Apr 2, 2024 · 2 comments · Fixed by #6260
Assignees
@fortmarek
Labels
type:bug Something isn't working

Comments

@kapitoshka438
Copy link
Contributor

What happened?

I don't know why KSCrash chose such a weird naming but Tuist cannot deal with it.
I would post an issue to the KSCrash repo itself but it works well with native Xcode SPM. Seems like it just renames the SPM product's modules names by replacing "/" with "_".

Here is how it's recognized if was added as an SPM dependency through Xcode:
Снимок экрана 2024-04-02 в 21 17 48

How do we reproduce it?

Add KSCrash to the Package.swift:

.package(url: "https://github.com/kstenerud/KSCrash", exact: "1.17.0"),

Add KSCrash to a target dependency:

.external(name: "KSCrash"),

Run tuist cache or tuist generate --no-binary-cache

Error log

Targets to be cached: KSCrash/Installations, KSCrash/Recording, KSCrash/Recording/Monitors, KSCrash/Recording/Tools, KSCrash/Reporting/Filters, KSCrash/Reporting/Filters/Tools, KSCrash/Reporting/Sinks, KSCrash/Reporting/Tools, KSCrash/swift/Basic, KSCrash_KSCrash/Recording
Loading and constructing the graph
It might take a while if the cache is empty
Using cache binaries for the following targets: 
Invalid bundle identifier 'KSCrash/Installations'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Recording'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Recording.resources'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Recording/Monitors'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Recording/Tools'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Reporting/Filters'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Reporting/Filters/Tools'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Reporting/Tools'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/Reporting/Sinks'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
Invalid bundle identifier 'KSCrash/swift/Basic'. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.

macOS version

14.4.1

Tuist version

4.8.1

Xcode version

15.3
@kapitoshka438 kapitoshka438 added the type:bug Something isn't working label Apr 2, 2024
@fortmarek fortmarek self-assigned this Apr 4, 2024
@TopIvanAbramov
Copy link

@fortmarek Hello! did you succeed to resolve the issue?

@mojidabckuu
Copy link

Faced the same issue.

Looks like bundleId is taken from the package's target name and targetSettings from Package.swift/Dependencies.swift are applied during the generation process. Not before tuist linting.

Any ideas how to unblock? Can't use the KSCrash

@kapitoshka438 kapitoshka438 mentioned this issue May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fortmarek fortmarek

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix integration of SPM packages with slashes in their targets names kapitoshka438/tuist
4 participants
@mojidabckuu @kapitoshka438 @fortmarek @TopIvanAbramov