Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated -package-name disappears if package defines swiftSettings #6203

Closed
ffittschen opened this issue Apr 17, 2024 · 1 comment · Fixed by #6299
Closed

Generated -package-name disappears if package defines swiftSettings #6203

ffittschen opened this issue Apr 17, 2024 · 1 comment · Fixed by #6299
Labels
type:bug Something isn't working

Comments

@ffittschen
Copy link
Contributor

ffittschen commented Apr 17, 2024

What happened?

When a Swift Package that uses the package access level also defines swiftSettings in their Package.swift, the -package-name generated by Tuist will not be present in the OTHER_SWIFT_FLAGS of the generated target. E.g as with the jwt-kit package:

https://github.com/vapor/jwt-kit/blob/9369604bc0cdf3b9d8cfc0305aa750ec8d8a8085/Package.swift#L29-L31

How do we reproduce it?

  1. Use the attached sample project
  2. Run tuist install
  3. Run tuist generate
  4. Open the workspace
  5. Inspect the OTHER_SWIFT_FLAGS of the jwt-kit target

jwt-kit-example.zip

Error log

'base64URLDecodedBytes' has a package access level but no -package-name was specified: /.../Tuist/.build/checkouts/jwt-kit/Sources/JWTKit/Utilities/Base64URL.swift

macOS version

14.4.1

Tuist version

4.9.0

Xcode version

15.3

@ffittschen ffittschen added the type:bug Something isn't working label Apr 17, 2024
@ffittschen ffittschen changed the title Option -package-name disappears if package defines swiftSettings Generated -package-name disappears if package defines swiftSettings Apr 17, 2024
@fortmarek
Copy link
Member

Thanks for flagging this. I put up a fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants