Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability issues with a sub dependency #429

Closed
ooade opened this issue Apr 28, 2018 · 6 comments
Closed

Vulnerability issues with a sub dependency #429

ooade opened this issue Apr 28, 2018 · 6 comments

Comments

@ooade
Copy link

ooade commented Apr 28, 2018

Here is a screenshot of the issue made by GitHub:
vulnerability

Tracing the graph, I have this:

└─┬ twit@2.2.9
  └─┬ request@2.85.0
    └─┬ hawk@6.0.2
      ├─┬ boom@4.3.1
      │ └── hoek@4.2.1  deduped
      ├─┬ cryptiles@3.1.2
      │ └─┬ boom@5.2.0
      │   └── hoek@4.2.1  deduped
      ├── hoek@4.2.1 
      └─┬ sntp@2.1.0
        └── hoek@4.2.1  deduped

Updating the request package might fix this 🤷‍♂️

@Ilshidur
Copy link

Ilshidur commented May 14, 2018

There is also a vulnerability in twit@2.2.9 › request@2.85.0 › stringstream@0.0.5 according to Snyk.

EDIT : Opened a issue : mhart/StringStream#7

@ChALkeR
Copy link

ChALkeR commented May 15, 2018

request/request#2885 with request#81f8cb57bbc landed and a new request version got released, so this can be closed now, I think.

@ttezel
Copy link
Owner

ttezel commented May 30, 2018

Hmm according to snyk, there are currently no known vulnerabilities in the twit dependency graph: https://snyk.io/test/npm/twit

@ttezel
Copy link
Owner

ttezel commented May 30, 2018

@Ilshidur and @ChALkeR all good to close this?

@Ilshidur
Copy link

@ttezel Yes I believe this issue can be closed now.

@ooade ooade closed this as completed May 30, 2018
@ChALkeR
Copy link

ChALkeR commented May 30, 2018

@ooade That was probably an issue in your package-lock file, it freezes nested deps.
Just updating, deleting, or rebuilding it should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants