Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provision/docker: use /logs endpoint to get logs from a container #811

Closed
fsouza opened this issue Jun 9, 2014 · 3 comments
Closed

provision/docker: use /logs endpoint to get logs from a container #811

fsouza opened this issue Jun 9, 2014 · 3 comments
Labels
docker enhancement
Milestone
0.9.0

Comments

@fsouza
Copy link
Contributor

fsouza commented Jun 9, 2014

Docker 0.11 introduced the /logs endpoint. It's available in the go-dockerclient via the Logs method. We should add it.

We must not forget that using the method will make tsuru incompatible with Docker pre-1.0.0 (which is fair, imo).
@fsouza fsouza added this to the 0.5.0 milestone Jun 9, 2014
fsouza pushed a commit that referenced this issue Jun 9, 2014
Godeps: update docker-cluster
3d3a4ee 
Related to #811.
@andrewsmedina andrewsmedina modified the milestones: 0.6.0, 0.5.0 Jun 10, 2014
@fsouza fsouza modified the milestone: 0.6.0 Jul 14, 2014
@fsouza
Copy link
Contributor Author

fsouza commented Jul 14, 2014

I'm putting this issue on hold. See moby/moby#7020.

@fsouza fsouza removed this from the 0.6.0 milestone Jul 14, 2014
@fsouza fsouza added the on hold label Jul 14, 2014
@fsouza fsouza removed the enhancement label Aug 8, 2014
@fsouza
Copy link
Contributor Author

fsouza commented Aug 27, 2014

moby/moby#7020 is now fixed. It will probably be included in the 1.3 release of Docker.

I'm adding this issue to the 0.8.0 milestone.

@fsouza fsouza added this to the 0.8.0 milestone Aug 27, 2014
@fsouza fsouza self-assigned this Oct 14, 2014
@fsouza
Copy link
Contributor Author

fsouza commented Oct 14, 2014

Moving this to milestone 0.9.0, because we don't want tsuru 0.8.0 to depend on Docker 1.3.

@fsouza fsouza removed their assignment Oct 14, 2014
@fsouza fsouza modified the milestones: 0.9.0, 0.8.0 Oct 14, 2014
@fsouza fsouza closed this as completed Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker enhancement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@andrewsmedina @fsouza