Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin 1.9.10 #394

Closed
wants to merge 7 commits into from
Closed

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Sep 20, 2023

Note - I have no plans to update this for Kotlin 1.9.20, see #394 (comment).


@BoD I hope you don't mind but I've forked your PR #388 as I've also spent time trying to upgrade to a more recent Kotlin version and looking into the failures. The missing piece is the last commit 7969038. I also rebased on #380 as that's where some of the initial changes came from.

@3flex 3flex changed the title Kotlin 1.9.20 Support Kotlin 1.9.10 Oct 4, 2023
@3flex 3flex marked this pull request as ready for review October 4, 2023 16:27
@3flex
Copy link
Contributor Author

3flex commented Oct 4, 2023

@tschuchortdev please take a look and let me know if anything's missing, I'll be happy to update.

Including klibs from the classpath is the biggest change required to support Kotlin/JS in newer releases.

@BoD
Copy link
Contributor

BoD commented Oct 4, 2023

I hope you don't mind but I've forked your PR

Not at all. This is great! And hope this can be merged/released 👍

@3flex 3flex mentioned this pull request Oct 8, 2023
drewhamilton added a commit to drewhamilton/Poko that referenced this pull request Oct 12, 2023
tschuchortdev/kotlin-compile-testing#394 works as needed, but isn't released. This unblocks Poko from that release.
drewhamilton added a commit to drewhamilton/Poko that referenced this pull request Oct 26, 2023
tschuchortdev/kotlin-compile-testing#394 works as needed, but isn't released. This unblocks Poko from that release.
drewhamilton added a commit to drewhamilton/Poko that referenced this pull request Oct 31, 2023
* Fully support use of Kotlin EAP versions
* Remove workaround for failing K2 toString on native target (KT-61616)
* Remove explicit declarations workaround (KT-61627)
* Use a local copy of Kotlin Compile Testing: tschuchortdev/kotlin-compile-testing#394 works as needed, but isn't released
* Update version table
@3flex
Copy link
Contributor Author

3flex commented Oct 31, 2023

1.9.20 is in process of being released, and I spent more time updating this PR to be compatible, but ran into a couple of issues.

I found this fork, which I plan to switch to, as it's already updated to Kotlin 1.9.20: https://github.com/ZacSweers/kotlin-compile-testing. The declared goal of the fork is to keep up to date with new Kotlin releases and Zac as some will know is a very active developer who already maintains a number of smaller Kotlin-related projects, so I have faith that the fork will continue to be maintained.

I'll leave this open in case it's merged but I have no plans to update it for 1.9.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kotlin 1.9.20 Support Kotlin 1.8.21
3 participants