Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.statSync no longer mocked from NodeJS 20.8.0 #380

Open
andrewnicols opened this issue Oct 2, 2023 · 3 comments
Open

fs.statSync no longer mocked from NodeJS 20.8.0 #380

andrewnicols opened this issue Oct 2, 2023 · 3 comments

Comments

@andrewnicols
Copy link

Mocking with mock-fs and call fs.statSync no longer mocks from v20.8.0
https://nodejs.org/en/blog/release/v20.8.0

I believe this is due to performance improvements in fs.*Sync methods from this commit: https://github.com/nodejs/node/pull/49593/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad

All *Sync commans hae moved to syncFs.
@andrewnicols andrewnicols mentioned this issue Oct 2, 2023
Merged
@brendandburns brendandburns mentioned this issue Oct 5, 2023
Closed
@andrewnicols andrewnicols mentioned this issue Oct 13, 2023
Draft
@noahtallen noahtallen mentioned this issue Oct 27, 2023
Merged
@nicokaiser nicokaiser mentioned this issue Oct 31, 2023
Open
@matt-boris matt-boris mentioned this issue Nov 1, 2023
Closed
@jbudz jbudz mentioned this issue Nov 10, 2023
Merged
@neilime neilime mentioned this issue Nov 11, 2023
Merged
theoludwig added a commit to leon-ai/leon-cli that referenced this issue Nov 14, 2023
@theoludwig
ci: usage of Node.js v18 (instead of v20) to accommodate mock-fs issue
5fb2fc2 
Ref: tschaub/mock-fs#377, tschaub/mock-fs#380
@jorpic jorpic mentioned this issue Nov 15, 2023
Closed
@mrgrain mrgrain mentioned this issue Nov 15, 2023
Merged
github-merge-queue bot pushed a commit to aws/jsii-rosetta that referenced this issue Nov 15, 2023
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
f25a394 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@fabioh8010 fabioh8010 mentioned this issue Nov 16, 2023
Merged
58 tasks
This was referenced Nov 20, 2023
Open
Open
@Sayan751
Copy link

Sayan751 commented Dec 2, 2023

I am also facing issues on Node 20 with exists*.

@ryanblock ryanblock mentioned this issue Dec 2, 2023
Closed
patrickjuchli added a commit to patrickjuchli/basic-ftp that referenced this issue Dec 9, 2023
@patrickjuchli
Fix unit tests for file download
47c88d5 
Mock-FS is no longer reliable, see tschaub/mock-fs#380.
Rewrite tests to use real file system instead.
@fregante
Copy link

This pushed me to just use async methods instead of *Sync. Those work perfectly in Node 20 with mock-fs 🎉

@travi travi mentioned this issue Dec 15, 2023
Merged
hegemonic added a commit to hegemonic/jsdoc-baseline that referenced this issue Dec 20, 2023
@hegemonic
chore: remove mock-fs from tests
5197a42 
It has some nasty, hard-to-fix bugs in current versions of Node.js (tschaub/mock-fs#377, tschaub/mock-fs#380) and an uncertain future (tschaub/mock-fs#383).

Also, this package's tests don't really need to mock the entire filesystem; they just need to write files to a temp directory that can be deleted when the tests are complete.
@Sayan751
Copy link

Sayan751 commented Jan 3, 2024

This pushed me to just use async methods instead of *Sync. Those work perfectly in Node 20 with mock-fs 🎉

Thanks @fregante! This works!

aws-cdk-automation pushed a commit to aws/jsii-rosetta that referenced this issue Jan 10, 2024
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
23a0037 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit f25a394)

# Conflicts:
#	.projen/deps.json
#	.projen/tasks.json
#	package.json
#	yarn.lock
aws-cdk-automation pushed a commit to aws/jsii-rosetta that referenced this issue Jan 10, 2024
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
365abb0 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit f25a394)

# Conflicts:
#	.projen/deps.json
#	.projen/tasks.json
#	package.json
#	yarn.lock
aws-cdk-automation pushed a commit to aws/jsii-rosetta that referenced this issue Jan 10, 2024
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
9194c34 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit f25a394)

# Conflicts:
#	.projen/deps.json
#	.projen/tasks.json
#	package.json
#	yarn.lock
aws-cdk-automation pushed a commit to aws/jsii-rosetta that referenced this issue Jan 10, 2024
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
174213f 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit f25a394)

# Conflicts:
#	.projen/deps.json
#	.projen/tasks.json
#	package.json
#	yarn.lock
aws-cdk-automation pushed a commit to aws/jsii-rosetta that referenced this issue Jan 10, 2024
@mrgrain
chore: replace mock-fs with memfs that works in node20 (#355)
62c7cd1 
We are affected by this `mock-fs` bug:
tschaub/mock-fs#380
Seems like there is no activity on the repo recently, so we switch to a
new tool.

However `memfs` only works for the test case in `assemblies.test.ts`.
So we keep `mock-fs` for the `rosetta.test.ts` test cases.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

(cherry picked from commit f25a394)

# Conflicts:
#	.projen/deps.json
#	.projen/tasks.json
#	package.json
#	yarn.lock
@JounQin JounQin mentioned this issue Jan 16, 2024
Merged
theoludwig added a commit to theoludwig/html-w3c-validator that referenced this issue Jan 30, 2024
@theoludwig
ci: usage of Node.js v18 (instead of v20) to accommodate mock-fs issue
b11b3db 
Ref: tschaub/mock-fs#377, tschaub/mock-fs#380
@tschaub tschaub mentioned this issue Feb 20, 2024
Closed
@lotas lotas mentioned this issue Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewnicols @fregante @Sayan751