Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird require.extensions after requiring mock-fs #115

Closed
tomek-he-him opened this issue May 18, 2016 · 3 comments
Closed

Weird require.extensions after requiring mock-fs #115

tomek-he-him opened this issue May 18, 2016 · 3 comments

Comments

@tomek-he-him
Copy link

Hi, thanks for this great library!

I run into a problem with mock-fs setting a weird { '.coffee': undefined } property on the global require.extensions object. This caused a problem when paired with node-dev. The problem I’ve described in the PR only appears when I require('mock-fs') in my tests.

I’ve fixed the interop on the node-dev side, so it’s not an urgent thing for me. But you might want to investigate this further.

@tschaub
Copy link
Owner

tschaub commented May 18, 2016

Thanks for the report. It looks like this is added by the rewire package.

I've proposed jhnns/rewire#98 as a fix for the issue. I'll leave this open until it is addressed upstream and we can pull in a fix here.

@tschaub
Copy link
Owner

tschaub commented Jul 1, 2016

Fix pulled in with #132. No more weird require.extensions properties in the next release.

@tschaub tschaub closed this as completed Jul 1, 2016
@tomek-he-him
Copy link
Author

tomek-he-him commented Jul 3, 2016

🙌 Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants