Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for riscv64 and riscv32 #66

Closed
wants to merge 1 commit into from
Closed

Conversation

luhenry
Copy link

@luhenry luhenry commented Nov 4, 2022

The OpenJDK sets os.arch to riscv64 or riscv32. This trips the architecture detection as it assumes the os.arch=riscv on RISC-V. Adds support for riscv32 and riscv64 to return riscv regardless. The bitness will be detected in guessBitnessFromArchitecture

The OpenJDK sets `os.arch` to `riscv64` or `riscv32`. This trips the architecture detection as it assumes the `os.arch=riscv` on RISC-V. Adds support for `riscv32` and `riscv64` to return `riscv` regardless. The bitness will be detected in `guessBitnessFromArchitecture`
@trustin
Copy link
Owner

trustin commented Nov 7, 2022

Thanks for the PR, @luhenry. I realized #62 is already filed by @zinovya. Let me merge his PR after adding support for riscv32 to it. One differnce is that riscv64 will be detected as riscv64 instead of riscv, because otherwise it will break the consistency, e.g. x86_32 vs x86_64.

@trustin trustin closed this Nov 7, 2022
@trustin trustin added this to the 1.7.1 milestone Nov 7, 2022
@luhenry
Copy link
Author

luhenry commented Nov 7, 2022

Perfect, thanks for merging it in, and thanks for taking care of this project! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants