Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signed commit in trunk-io/trunk-action/upgrade #764

Open
yu-iskw opened this issue May 2, 2024 · 3 comments
Open

Support signed commit in trunk-io/trunk-action/upgrade #764

yu-iskw opened this issue May 2, 2024 · 3 comments

Comments

@yu-iskw
Copy link
Contributor

yu-iskw commented May 2, 2024 •
edited

Let me open the feature request in the repository, since trunk-io/trunk-action doesn't allow me to create issues.

Currently, trunk-io/trunk-action/upgrade doesn't support signed commit. If we turn on the setting that commit is required in a GitHub repository, the check doesn't pass. So, it would be great to support signed commit in the action.

image
@TylerJang27
Copy link
Collaborator

Hi @yu-iskw! Thanks for bringing this up! I'll talk to the owning team about making sure that repo supports issues.

In the meantime, we'll look into seeing if we can get signed commits working for that action.

@puzzler7 puzzler7 mentioned this issue May 8, 2024
Merged
puzzler7 added a commit to trunk-io/trunk-action that referenced this issue May 8, 2024
@puzzler7
feat: add option for Signed-Off-By line in upgrade action (#238)
bd68632 
Adds support for adding a `Signed-Off-By` line to commits created by the
upgrade action, as requested
[here](trunk-io/plugins#764).

Tested in this repo, you can see the commit
[here](cc7d39d).
@TylerJang27
Copy link
Collaborator

@yu-iskw we've released trunk-io/trunk-action/upgrade@v1.1.14, which has an option for signoff. This should be sufficient for the DCO app.

If this is insufficient and you also need the commit to be signed and verified, please let us know and we can look into supporting that.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented May 23, 2024

@TylerJang27 Thank you so much. I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yu-iskw @TylerJang27