Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Remove deprecated networks when creating a forked ganache instance #246

Open
kevinbluer opened this issue Oct 26, 2022 · 4 comments
Open
Assignees
Labels
enhancement New feature or request priority1 🚨

Comments

@kevinbluer
Copy link
Member

kevinbluer commented Oct 26, 2022

When creating a forked Ganache instance (Create new network | Ganache service | Fork) the following are returned:

Screen Shot 2022-10-26 at 2 07 28 PM

Given Ropsten, Kovan, and Rinkeby are now deprecated we should remove them.

EDIT - We should also add the Sepolia testnet.

@kevinbluer kevinbluer added the enhancement New feature or request label Oct 26, 2022
@kevinbluer
Copy link
Member Author

This might warrant a separate issue but we'll also need to address on the Infura returned networks too:

Screen Shot 2022-10-26 at 2 24 06 PM

@michaeljohnbennett michaeljohnbennett changed the title Remove depreciated networks when creating a forked ganache instance Remove deprecated networks when creating a forked ganache instance Oct 27, 2022
@michaeljohnbennett michaeljohnbennett self-assigned this Oct 27, 2022
@michaeljohnbennett
Copy link
Contributor

michaeljohnbennett commented Oct 27, 2022

I have had a look at this and it appears the list for the Infura section at least, is coming directly from the API calls.

I think we will need to ask Infura about updating the API on their end or moving/upgrading our API calls to a newer API version.

@michaeljohnbennett
Copy link
Contributor

Code is changed our side, need to confirm that sepolia forking is working correctly into ganache from the extension.

@michaeljohnbennett
Copy link
Contributor

ok I have fixed the requirements page as part of this too.

Requirements are now driven from our constants correctly, stopping duplication of values/mismatches on the HTML page.

Sepolia working on Ganache >7.4.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority1 🚨
Projects
No open projects
Development

No branches or pull requests

3 participants