Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Lightweight Scribble integration (arm / disarm / etc) under Integrations #209

Open
kevinbluer opened this issue Aug 16, 2022 · 4 comments
Open
Assignees
Labels
enhancement New feature or request needs requirements

Comments

@kevinbluer
Copy link
Member

kevinbluer commented Aug 16, 2022

Following #208, Scribble integration could be a nice additional candidate. High-level thoughts as follows...

  • Check to see if Scribble is installed and prompt to do so if not
  • Include ability to arm / disarm
  • Ability to check properties with MythX / Mythril / other
@michaeljohnbennett
Copy link
Contributor

At what level do we want to do this?

Is arm/disarm globally? Or are we wanting to do this specifically per file?

@acuarica
Copy link
Contributor

I'm assuming when you say globally, it means to act on every contract. If so, I would say, ideally to have both options, on all files and individually. The scribble command itself acts on a single file, so this might be a more important use case.

@michaeljohnbennett
Copy link
Contributor

we need to know which contracts are armable too? Looking for scribble annotations?

@acuarica
Copy link
Contributor

acuarica commented Nov 1, 2022

In a first pass, I would do something simpler, just an interface for its command, regardless of any annotations in the contract. We could parse Scribble's output to notify the user if any instrumentation actually happened.

In case we want to inform the user beforehand, we'll need some sort of Scribble's annotation parser.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request needs requirements
Projects
None yet
Development

No branches or pull requests

3 participants