Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Truffle debugger/decoder can't handle certain ENS names in reverse resolution; reports them as not existing #6088

Open
haltman-at opened this issue Jun 13, 2023 · 0 comments

Comments

@haltman-at
Copy link
Contributor

haltman-at commented Jun 13, 2023

Issue

This issue is a followup to #6083. Right now, debugger and decoder use ENSJS to perform ENS resolution (forward and backward).

The problem is that ENSJS will throw on forward resolution if the ENS name contains certain characters that are (under certain circumstances?) not allowed in a URL. However, it is perfectly happy to return those characters when performing a reverse resolution.

We should figure out how to make it allow those characters, or switch to a different library that doesn't have a problem with this, or just do things ourself (although that's obviously a bunch of work).

Reproduction steps

See "testing instructions" in #6083. The address 0xa39739ef8b0231dbfa0dcda07d7e29faabcf4bb2 appearing in the TroveOwners variable should have an ENS name listed of 🍑🪴🤝⚔🛡.eth (assuming forward really does match backward, which I didn't check). Right now, it has none listed, due to the problem above.

Note: 🍑 seems to be fine, but 🪴 causes a problem!

Environment

  • Truffle version (truffle version): 5.9.4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants