Add s3 object count to trace logs #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-rich
force-pushed
the
THOG-856_Add_object_count
branch
from
55065fa
to
aa55f86
Compare
mcastorina
reviewed
Dec 14, 2022
main.go
Outdated
Comment on lines
121
to
122
| log.SetLevel(3) | ||
| log.SetLevelForControl(logLevel, 3) |
There was a problem hiding this comment.
We may want to use 2 here to match what we have in enterprise.
There was a problem hiding this comment.
We could also solely rely on the globalLogLevel that is set via log.SetLevel.. in other words I think we could remove the logLevel variable altogether.
There was a problem hiding this comment.
I thought the same, but it doesn't seem to work without the SetLevelForControl. I'm not super familiar with the logging setup, so I'm not sure why that is.
There was a problem hiding this comment.
I think when we do log.WithLeveler it replaces the default global with the one we provide. We could probably just remove the control entirely, but that can happen in another PR.
mcastorina
approved these changes
Dec 14, 2022
javajawa
added a commit
to mewbotorg/mewbot
that referenced
this pull request
Dec 26, 2022
Update trufflehog from 3.19.0 to 3.21.0. - Bump github.com/xanzy/go-gitlab from 0.76.0 to 0.77.0 by @dependabot in trufflesecurity/trufflehog#981 - Bump golang.org/x/crypto from 0.3.0 to 0.4.0 by @dependabot in trufflesecurity/trufflehog#982 - Add configuration parsing and custom detectors to engine by @mcastorina in trufflesecurity/trufflehog#968 - Add custom regex detector docs by @mcastorina in trufflesecurity/trufflehog#983 - Remove custom log leveler by @mcastorina in trufflesecurity/trufflehog#985 - Bump github.com/xanzy/go-gitlab from 0.74.0 to 0.76.0 by @dependabot in trufflesecurity/trufflehog#934 - Bump github.com/bill-rich/disk-buffer-reader from v0.1.6 to v0.1.7 by @bill-rich in trufflesecurity/trufflehog#970 - Bump go.mongodb.org/mongo-driver from 1.11.0 to 1.11.1 by @dependabot in trufflesecurity/trufflehog#971 - Bump github.com/getsentry/sentry-go from 0.15.0 to 0.16.0 by @dependabot in trufflesecurity/trufflehog#973 - [bug] - Handle error when scanning s3 bucket. by @ahrav in trufflesecurity/trufflehog#969 - Bump github.com/go-git/go-git/v5 from 5.4.2 to 5.5.1 by @dependabot in trufflesecurity/trufflehog#972 - Bump github.com/envoyproxy/protoc-gen-validate from 0.6.13 to 0.9.1 by @dependabot in trufflesecurity/trufflehog#963 - Add more logging for git sources by @mcastorina in trufflesecurity/trufflehog#974 - Add s3 object count to trace logs by @bill-rich in trufflesecurity/trufflehog#975 - Implement CustomRegex detector by @mcastorina in trufflesecurity/trufflehog#950 - Use Todoist's REST API v2 by @goncalossilva in trufflesecurity/trufflehog#978 - Allow using a glob for include list. by @ahrav in trufflesecurity/trufflehog#977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.