Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't scan the --since-commit target #960

Merged
merged 1 commit into from Dec 6, 2022
Merged

Don't scan the --since-commit target #960

merged 1 commit into from Dec 6, 2022

Conversation

bill-rich
Copy link
Collaborator

The commit in --since-commit should not be scanned or pre-commit hooks won't work when head of main branch includes a secret.

@bill-rich bill-rich requested review from a team as code owners December 6, 2022 21:19
mcastorina
mcastorina approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@bill-rich bill-rich merged commit 33d32d2 into main Dec 6, 2022
@bill-rich bill-rich deleted the THOG-869_Precommit_fixes branch December 6, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bill-rich @mcastorina