Change chunker test source #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
reviewed
Dec 6, 2022
pkg/sources/chunker.go
Outdated
Comment on lines
40
to
43
| chunkChan <- &chunk | ||
| if errors.Is(err, io.EOF) { | ||
| break | ||
| } | ||
| chunkChan <- &chunk |
There was a problem hiding this comment.
Question: I guess this is implementation dependent, but could we have read data and gotten an EOF error? Maybe we should emit the chunk only if n > 0.
There was a problem hiding this comment.
Good call. Better to have the catch there just in case.
mcastorina
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a reader with a predetermined size to limit error sources.