Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update slack webhook detector string check #932

Merged
merged 2 commits into from Nov 21, 2022
Merged

Update slack webhook detector string check #932

merged 2 commits into from Nov 21, 2022

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 20, 2022

  • Check for text instead of missing_text as there are versions of slack webhooks that return no_text.

@ahrav ahrav requested a review from a team as a code owner November 20, 2022 05:40
@ahrav ahrav linked an issue Nov 20, 2022 that may be closed by this pull request
[BUG] Slack Webhook Detector Validation #880
Closed
@dustin-decker dustin-decker merged commit 054e98d into main Nov 21, 2022
@dustin-decker dustin-decker deleted the 880-bug-slack-webhook-detector-validation branch November 21, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Slack Webhook Detector Validation
3 participants
@ahrav @mcastorina @dustin-decker