Enable skipping of particular key IDs #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Nov 18, 2022
| @@ -72,6 +97,12 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| } | |||
| resIDMatch := strings.TrimSpace(idMatch[1]) | |||
|
|
|||
| if s.skipIDs != nil { | |||
There was a problem hiding this comment.
Nit (optional): I think s.skipIDs is always non-nil since it's initialized in New()
There was a problem hiding this comment.
Yeah, it's probably not needed now since I made the struct not exported.
trufflesteeeve
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we would have separate detect+verify calls to apply this logic, but we don't, and the use case is fairly limited, so just configuring it at initialization time right now.
Another option is just to run this detector twice with verify=false and verify=true.