Add custom detectors configuration parsing #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also create protoyaml package to test YAML unmarshalling the configuration.
| repeated string keywords = 1; | ||
| map<string, string> regex = 2; | ||
| repeated VerifierConfig verify = 3; | ||
| } |
There was a problem hiding this comment.
I think we probably want to combine CustomDetector and CustomRegex together here. Because in config, I think it makes sense for them to be an array of maps containing all of the custom detectors, and the custom detector itself would look like CustomRegex plus the name. We might not actually need type for these, and I think we can forego having connection and instead combine these two messages into one. e.g.
message CustomDetector {
string type = 1;
string name = 2;
repeated string keywords = 3;
map<string, string> regex = 4;
repeated VerifierConfig verify = 6;
}
trufflesteeeve
approved these changes
Nov 21, 2022
Comment on lines
+12
to
+26
| const testCustomRegexYaml = `name: Internal bi tool | ||
| keywords: | ||
| - secret_v1_ | ||
| - pat_v2_ | ||
| regex: | ||
| id_pat_example: ([a-zA-Z0-9]{32}) | ||
| secret_pat_example: ([a-zA-Z0-9]{32}) | ||
| verify: | ||
| - endpoint: http://localhost:8000/{id_pat_example} | ||
| unsafe: true | ||
| headers: | ||
| - 'Authorization: Bearer {secret_pat_example.0}' | ||
| successRanges: | ||
| - 200-250 | ||
| - '288'` |
There was a problem hiding this comment.
I think we need to revisit the design document, this is not what was proposed and reviewed previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.