Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make type fields optional and add JSDoc #180

Merged
merged 3 commits into from Nov 18, 2022

Conversation

leomotors
Copy link
Contributor

In the last PR, I made some mistakes there about forgetting to make some options optional. Sorry for that 馃槄.

In addition to that, I add JSDoc because I think it is nice to have.

I also type the importOrderParserPlugins with the appropriate type to help with checking and autocomplete.

IanVS added a commit to IanVS/prettier-plugin-sort-imports that referenced this pull request Oct 26, 2022
Ported from trivago/prettier-plugin-sort-imports#173 & trivago/prettier-plugin-sort-imports#180

We'll likely be deprecating many of these options in the future, but for now, we may as well expose their types and give them some nice docs.

Co-authored-by: Nutthapat Pongtanyavichai <59821765+Leomotors@users.noreply.github.com>
@ayusharma ayusharma merged commit 3c2a871 into trivago:master Nov 18, 2022
@byara
Copy link
Collaborator

byara commented Nov 24, 2022

Released in v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants