Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep refresh token if the server does not return a new one on token refresh #83

Closed
wants to merge 1 commit into from
Closed

Keep refresh token if the server does not return a new one on token refresh #83

wants to merge 1 commit into from

Conversation

poislagarde
Copy link
Contributor

Closes #82

@poislagarde
Copy link
Contributor Author

Have you gotten the chance to take a look at this? Let me know what you guys think

@bckr bckr self-assigned this Jun 13, 2016
bckr
bckr reviewed Jun 13, 2016
View reviewed changes
Heimdallr/Core/Heimdallr.swift
/// - parameter accessToken: The new access token.
///
/// - returns: The updated access token.
private func updateAccessToken(accessToken: OAuthAccessToken) -> OAuthAccessToken {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer this being part of the set part of accessToken just so that we always get the expected behaviour when setting a new token directly. What do you think?

@bckr
Copy link
Contributor

bckr commented Jun 13, 2016

@poislagarde Thanks for the nice pull request! 🎉

I've added some smaller comments. When those are addressed, I would be happy to merge this 👍

@poislagarde
Copy link
Contributor Author

@bckr sorry about the delay. I'll try to look at this during the weekend!

@bckr
Copy link
Contributor

bckr commented Jul 15, 2016

@poislagarde Awesome 👍

@tibr tibr unassigned bckr Jul 20, 2016
@poislagarde poislagarde closed this by deleting the head repository Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep refresh token if the server does not return a new one on token refresh
2 participants
@poislagarde @bckr