-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Nushell's syntax #524
Comments
typically syntaxes are included as git submodules, so dependabot can easily create PRs to bump them automatically |
Thanks for the info! 🙏🏻 I still can't work out the mechanic to include a new syntax. e.g. if I search the syntect repo for erlang, I don't find anything... |
did you checkout submodules? Erlang is in |
I think I see. It looks like if In which case, my next step is to try to get https://github.com/kurokirasama/nushell_sublime_syntax added to https://github.com/sublimehq/Packages ah, but sublimehq/Packages isn't accepting new packages |
would it be reasonable to add https://github.com/kurokirasama/nushell_sublime_syntax as an additional submodule, perhaps to: testdata/MoarPackages, and to update the build to load syntax from testdata/Packages + testdata/MoarPackages? .. or something roughly along those lines? |
It may be reasonable, but I'm not yet convinced it's something we want in |
Ah gotcha. Yeah, that would quickly become impractical.
Right, I don't think I've been appreciating how straightforward it would be to just add the nushell schema to my consumer codebase. Beyond my own immediate use case, my motivation to have the schema included upstream is to help the nushell project become more mainstream, tooling-wise. It's a shame sublimehq/Packages isn't accepting PRs, but it also makes sense. They would be in a similar floodgate position. I'll close this issue for now. Thanks Keith 🙏🏻 syntect is a tremendous asset to the whole community. |
Hi!
How are new syntaxes added to the syntect crate?
It'd be great to have Nushell’s syntax available. @kurokirasama has a definition here: https://github.com/kurokirasama/nushell_sublime_syntax/blob/main/nushell.sublime-syntax
I'm curious if the mechanism that includes syntax definitions can source the definition directly from nushell_sublime_syntax, so updates are picked up automatically?
The text was updated successfully, but these errors were encountered: