Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov badge in the Readme is unintentionally misleading #496

Open
CosmicHorrorDev opened this issue Nov 14, 2023 · 0 comments
Open

codecov badge in the Readme is unintentionally misleading #496

CosmicHorrorDev opened this issue Nov 14, 2023 · 0 comments

Comments

@CosmicHorrorDev
Copy link
Contributor

The current coverage listed by the badge in the Readme (codecov) is quite low, but if you click through the link you'll see that coverage isn't actually being tracked on codecov anymore

Locally the coverage appears to be quite good (notably the line coverage is nearly 93%)

syntect on  master is 📦 v5.1.0 via 🦀 v1.73.0
❯ cargo +nightly llvm-cov
  -- 8< -- snip -- 8< --

Filename                    Regions  Missed Regions    Cover  Functions  Missed Functions  Executed  Lines  Missed Lines    Cover
---------------------------------------------------------------------------------------------------------------------------------
dumps.rs                         52              25   51.92%         20                 4    80.00%    114            17   85.09%
easy.rs                          75               7   90.67%         20                 4    80.00%    127             6   95.28%
escape.rs                        24               5   79.17%          1                 0   100.00%     24             2   91.67%
highlighting/highlighter.rs     119              12   89.92%         43                 8    81.40%    401             9   97.76%
highlighting/selector.rs        131              33   74.81%         28                 9    67.86%    259            11   95.75%
highlighting/settings.rs          9               4   55.56%          4                 3    25.00%      9             5   44.44%
highlighting/style.rs            91              73   19.78%         29                17    41.38%     69            43   37.68%
highlighting/theme.rs           195             186    4.62%         24                19    20.83%     26            21   19.23%
highlighting/theme_load.rs      204              56   72.55%         14                 5    64.29%    189            42   77.78%
highlighting/theme_set.rs        69              18   73.91%         15                 2    86.67%     78             2   97.44%
html.rs                         240              96   60.00%         40                14    65.00%    438           111   74.66%
lib.rs                            8               6   25.00%          4                 3    25.00%      4             3   25.00%
parsing/parser.rs               435              30   93.10%        115                 7    93.91%   1468             9   99.39%
parsing/regex.rs                 50               5   90.00%         28                 4    85.71%    120             6   95.00%
parsing/scope.rs                248              56   77.42%         81                21    74.07%    380            38   90.00%
parsing/syntax_definition.rs    247             134   45.75%         52                 5    90.38%    173             8   95.38%
parsing/syntax_set.rs           464              81   82.54%        113                11    90.27%    927            25   97.30%
parsing/yaml_load.rs            578              53   90.83%         84                 1    98.81%    951            22   97.69%
util.rs                         104              29   72.12%         19                 4    78.95%    215            41   80.93%
utils.rs                          1               0   00.00%          1                 0   100.00%      3             0  100.00%
---------------------------------------------------------------------------------------------------------------------------------
TOTAL                          3344             909   72.82%        735               141    80.82%   5975           421   92.95%

It seems like either the badge should be removed or coverage should start getting tracked again (through codecov or some other service)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant