Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider compressing SyntaxReference's variables #482

Open
CosmicHorrorDev opened this issue Jul 1, 2023 · 0 comments · May be fixed by #540
Open

Consider compressing SyntaxReference's variables #482

CosmicHorrorDev opened this issue Jul 1, 2023 · 0 comments · May be fixed by #540

Comments

@CosmicHorrorDev
Copy link
Contributor

From my understanding the separation for what gets compressed and what doesn't for SyntaxReferences are whether the values are expected to be used when trying to match on the syntax vs actually highlighting using the syntax. By that logic I believe that variables should also be compressed until used (lingering question: should this be included within LazyContexts or kept separate?)

The main motivation being that some syntax definitions have very large variables that wind up bloating the serialized size of SyntaxSets. For instance C.sublime-syntax has a window_types variable that's over a KiB (and bat's Julia sublime syntax has a variable with a value that's over 8 KiBs by itself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant