Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions: update to Node 16 #34

Closed
tripleee opened this issue Nov 14, 2022 · 7 comments
Closed

Github actions: update to Node 16 #34

tripleee opened this issue Nov 14, 2022 · 7 comments
Assignees

Comments

@tripleee
Copy link
Owner

Recent nightly jobs have this notice:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

@tripleee tripleee self-assigned this Nov 14, 2022
@tripleee
Copy link
Owner Author

Also, test-pushed gets this:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

It's not using set-output directly so I'm guessing it's related to the above.

@tripleee
Copy link
Owner Author

The documentation in the link is pretty nondescript; but I upgraded to v3 of actions/checkout which according to their README should get me to Node v16.

@tripleee
Copy link
Owner Author

The fix was insufficient; I still see the warning banner at the bottom of the build's page.

@tripleee tripleee reopened this Nov 15, 2022
@tripleee
Copy link
Owner Author

@tripleee
Copy link
Owner Author

actions/checkout#959 alleges that upgrading to v3 should fix this. Maybe let's just wait and check again.

@tripleee
Copy link
Owner Author

Actually, the warning is gone from the nightly job now. I guess something is still left in the push test to review. It also employs actions/setup-python@v2; there's a v4 available - let's try that.

@tripleee
Copy link
Owner Author

Yay, the banner is gone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant