From 8791f45b036866b071c193c037292a4972c4a0bf Mon Sep 17 00:00:00 2001 From: Marco Marche Date: Tue, 8 Jun 2021 12:04:38 +0200 Subject: [PATCH] build: remove dependency on @angular/elements and custom elements polyfill We weren't using `@angular/elements` for anything and the `custom-elements` polyfill was only included because of it. --- package.json | 1 - packages.bzl | 1 - src/dev-app/BUILD.bazel | 1 - src/dev-app/example/BUILD.bazel | 1 - src/dev-app/index.html | 8 +------- src/e2e-app/BUILD.bazel | 2 -- src/e2e-app/index.html | 8 -------- yarn.lock | 12 ------------ 8 files changed, 1 insertion(+), 33 deletions(-) diff --git a/package.json b/package.json index 2e12d734e9..e80257addd 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,6 @@ "@angular/common": "^12.0.0-rc.0", "@angular/compiler": "^12.0.0-rc.0", "@angular/core": "^12.0.0-rc.0", - "@angular/elements": "^12.0.0-rc.0", "@angular/forms": "^12.0.0-rc.0", "@angular/material": "^12.0.0-rc.0", "@angular/platform-browser": "^12.0.0-rc.0", diff --git a/packages.bzl b/packages.bzl index 0de7b7909f..c443517bd8 100755 --- a/packages.bzl +++ b/packages.bzl @@ -64,7 +64,6 @@ ANGULAR_NGCC_BUNDLES = [ ("@angular/common", ["common-http-testing.umd.js", "common-http.umd.js", "common-testing.umd.js", "common.umd.js"]), ("@angular/compiler", ["compiler-testing.umd.js"]), ("@angular/core", ["core-testing.umd.js", "core.umd.js"]), - ("@angular/elements", ["elements.umd.js"]), ("@angular/forms", ["forms.umd.js"]), ("@angular/material", ["material-autocomplete.umd.js", "material-button.umd.js", "material-button-toggle.umd.js", "material-card.umd.js", "material-checkbox.umd.js", "material-chips.umd.js", "material-core.umd.js", "material-dialog.umd.js", "material-divider.umd.js", "material-expansion.umd.js", "material-form-field.umd.js", "material-grid-list.umd.js", "material-icon.umd.js", "material-input.umd.js", "material-list.umd.js", "material-menu.umd.js", "material-radio.umd.js", "material-select.umd.js", "material-sidenav.umd.js", "material-slide-toggle.umd.js", "material-slider.umd.js", "material-table.umd.js", "material-tabs.umd.js", "material-toolbar.umd.js", "material-tooltip.umd.js"]), ("@angular/platform-browser-dynamic", ["platform-browser-dynamic-testing.umd.js", "platform-browser-dynamic.umd.js"]), diff --git a/src/dev-app/BUILD.bazel b/src/dev-app/BUILD.bazel index eb2c490ec0..e9708c3b38 100644 --- a/src/dev-app/BUILD.bazel +++ b/src/dev-app/BUILD.bazel @@ -72,7 +72,6 @@ filegroup( "@npm//:node_modules/@ajf/icons/fonts/ajf.woff", "@npm//:node_modules/@angular/material/prebuilt-themes/indigo-pink.css", "@npm//:node_modules/@ionic/angular/css/ionic.bundle.css", - "@npm//:node_modules/@webcomponents/custom-elements/custom-elements.min.js", "@npm//:node_modules/core-js-bundle/index.js", "@npm//:node_modules/flag-icon-css/css/flag-icon.min.css", "@npm//:node_modules/flag-icon-css/flags/4x3/bf.svg", diff --git a/src/dev-app/example/BUILD.bazel b/src/dev-app/example/BUILD.bazel index dd5fbdb468..753d23fdae 100644 --- a/src/dev-app/example/BUILD.bazel +++ b/src/dev-app/example/BUILD.bazel @@ -9,7 +9,6 @@ ng_module( "//src/ajf-examples", "//src/ajf-examples/private", "@npm//@angular/cdk", - "@npm//@angular/elements", "@npm//@angular/material", ], ) diff --git a/src/dev-app/index.html b/src/dev-app/index.html index b69e0cec72..1453d9018e 100644 --- a/src/dev-app/index.html +++ b/src/dev-app/index.html @@ -15,13 +15,7 @@ - - - + diff --git a/src/e2e-app/BUILD.bazel b/src/e2e-app/BUILD.bazel index aea714e30d..e238044c0f 100644 --- a/src/e2e-app/BUILD.bazel +++ b/src/e2e-app/BUILD.bazel @@ -34,7 +34,6 @@ ng_module( "//src/material/reports", "@npm//@angular/common", "@npm//@angular/core", - "@npm//@angular/elements", "@npm//@angular/forms", "@npm//@angular/platform-browser", "@npm//@angular/router", @@ -73,7 +72,6 @@ concatjs_devserver( "@npm//numbro", "@npm//pdfmake", "@npm//@ngx-translate/core", - "@npm//@webcomponents/custom-elements", ":index.html", ], tags = ["manual"], diff --git a/src/e2e-app/index.html b/src/e2e-app/index.html index a8eee6b534..4861fe049c 100644 --- a/src/e2e-app/index.html +++ b/src/e2e-app/index.html @@ -15,14 +15,6 @@ - - - - Loading... diff --git a/yarn.lock b/yarn.lock index f4d3d856de..02542d67e8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -163,13 +163,6 @@ yaml "^1.10.0" yargs "^16.2.0" -"@angular/elements@^12.0.0-rc.0": - version "12.0.0-rc.0" - resolved "https://registry.yarnpkg.com/@angular/elements/-/elements-12.0.0-rc.0.tgz#c01e3a00a121e6312240e82164cd941f08d0823e" - integrity sha512-WIwMxNesgpXp12kpfsgz++7oadJ4aQhxFzreqhUnGHGCS0GECbJU8EGSuqyO4TMRP5FZJRDgETRUqysa/wNfgQ== - dependencies: - tslib "^2.1.0" - "@angular/forms@^12.0.0-rc.0": version "12.0.0-rc.0" resolved "https://registry.yarnpkg.com/@angular/forms/-/forms-12.0.0-rc.0.tgz#1a1f71be85f8ad4e41a4ef9fe5dbef3bb04a5420" @@ -1464,11 +1457,6 @@ "@typescript-eslint/types" "4.14.0" eslint-visitor-keys "^2.0.0" -"@webcomponents/custom-elements@^1.1.0": - version "1.4.3" - resolved "https://registry.yarnpkg.com/@webcomponents/custom-elements/-/custom-elements-1.4.3.tgz#1800d49f38bb4425ebfd160b50115e62776109d7" - integrity sha512-iD0YW46SreUQANGccywK/eC+gZELNHocZZrY2fGwrIlx/biQOTkAF9IohisibHbrmIHmA9pVCIdGwzfO+W0gig== - "@zxing/library@^0.17.0": version "0.17.1" resolved "https://registry.yarnpkg.com/@zxing/library/-/library-0.17.1.tgz#4c82bf401391c2b79bfbab0a6b1143da6d8feb1a"