Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noopener to external links #371

Merged
merged 2 commits into from Oct 3, 2020
Merged

Conversation

alanhamlett
Copy link
Contributor

Adds rel="noopener" anytime a link contains target="_blank" for improved security.

https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener

@alanhamlett
Copy link
Contributor Author

The failing test isn't related to my code change.

@nicholasserra
Copy link
Collaborator

Thanks! I'll check this out asap. I fixed the test failure upstream.

@alanhamlett
Copy link
Contributor Author

I fixed the test failure upstream.

Cool, just rebased with the fix.

@alanhamlett
Copy link
Contributor Author

Ready to merge 😄

@nicholasserra nicholasserra merged commit 40050e7 into trentm:master Oct 3, 2020
@nicholasserra
Copy link
Collaborator

Thank you! I added one more test and cleaned up those nested conditionals a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants