Support for structured and nested values in metadata (#120) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/markdown2.py
Outdated
| kvm = re.findall(self._key_val_block_pat, metadata_content) | ||
| kvm = [item.replace(": >\n", ":", 1) for item in kvm] | ||
| def parse_structured_value(value): | ||
| print(repr(value)) |
There was a problem hiding this comment.
Can we nuke this print?
|
LGTM, thanks! Just had an extra |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request fixing #120. All tests passes. Existing test on metadata is extended to cover new cases.
Dict support
is now parsed as
key: {subkey: subvalue}List support
is now parsed as
key: ["one", "two"]Nested structured values support
is now parsed as
key: {subkey: ["Long text\n in structure"]Nota bene
key: subkey: subvalueis not supported.