New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add underline 'u' support in extras #360
Conversation
Signed-off-by: starry69 <starry369126@outlook.com>
Thanks! I need to do some research on Have any opinions? |
Yeah sure I'll do that |
Let me research first. I'll comment when I figure out what's best. |
Signed-off-by: starry69 <starry369126@outlook.com>
Yeah 'u' will look more better imo as per HTML5 documentation... |
Hi I've looked in internet and yes I think using 'u' would be better option here since we just want underline text support.. https://html.com/tags/u/ and https://html.com/tags/ins/ |
Cool, looks good. Seeing failing tests on this. |
Hmmm dunno tbh why test not passing, I've checked code before makeing a PR it seems to work fine tho |
You have an incorrect word in the test. Run the tests locally. |
Sure. I'll check |
Signed-off-by: starry69 <starry369126@outlook.com>
Fixed ;) |
Thanks! |
Signed-off-by: starry69 starry369126@outlook.com