Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underline 'u' support in extras #360

Merged
merged 3 commits into from Jun 26, 2020
Merged

Add underline 'u' support in extras #360

merged 3 commits into from Jun 26, 2020

Conversation

starry-shivam
Copy link
Contributor

Signed-off-by: starry69 starry369126@outlook.com

Signed-off-by: starry69 <starry369126@outlook.com>
@nicholasserra
Copy link
Collaborator

Thanks! I need to do some research on ins vs u. It seems u was not well supported, but now html5 supports u fully. Depending on that research we may just wanna change this over to u and underline as extra name.

Have any opinions?

@starry-shivam
Copy link
Contributor Author

Yeah sure I'll do that

@nicholasserra
Copy link
Collaborator

Let me research first. I'll comment when I figure out what's best.

Signed-off-by: starry69 <starry369126@outlook.com>
@starry-shivam
Copy link
Contributor Author

starry-shivam commented Jun 17, 2020

Yeah 'u' will look more better imo as per HTML5 documentation...

@starry-shivam
Copy link
Contributor Author

Hi I've looked in internet and yes I think using 'u' would be better option here since we just want underline text support.. https://html.com/tags/u/ and https://html.com/tags/ins/

@starry-shivam starry-shivam changed the title Add underline 'ins' support Add underline 'u' support in extras Jun 18, 2020
@nicholasserra
Copy link
Collaborator

Cool, looks good. Seeing failing tests on this.

@starry-shivam
Copy link
Contributor Author

Hmmm dunno tbh why test not passing, I've checked code before makeing a PR it seems to work fine tho

@nicholasserra
Copy link
Collaborator

You have an incorrect word in the test. Run the tests locally. make test should do it.

@starry-shivam
Copy link
Contributor Author

Sure. I'll check

Signed-off-by: starry69 <starry369126@outlook.com>
@starry-shivam
Copy link
Contributor Author

Fixed ;)

@nicholasserra
Copy link
Collaborator

Thanks!

@nicholasserra nicholasserra merged commit 6af16f4 into trentm:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants