Don't auto link patterns surrounded by """. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the prevention of `[WikiWikiWeb](http://wiki.c2.com/?WikiWikiWeb)` being transformed to `<a href="http://wiki.c2.com/?<a href="aw.cgi?page=WikiWikiWeb">WikiWikiWeb</a>">WikiWikiWeb</a>` when the pattern linker sees the second WikiCase word by surrounding it with triple quotes: so `[WikiWikiWeb](http://wiki.c2.com/?"""WikiWikiWeb""")` is now transformed to `<a href="http://wiki.c2.com/?WikiWikiWeb">WikiWikiWeb</a>`. The function responsible, _do_link_patterns(), already checked for the cases that the pattern was inside square brackets, or was preceeded by `](` or suffixed by `")`, and skips expanding in these cases. This addition simply adds a check that the pattern is not surrounded by triple quotes; the triple quotes are stripped from the output.
|
Thanks! Can you add a test case exercising the change in question? |
|
OK, will do |
|
And added! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the prevention of
[WikiWikiWeb](http://wiki.c2.com/?WikiWikiWeb)being transformed to<a href="http://wiki.c2.com/?<a href="aw.cgi?page=WikiWikiWeb">WikiWikiWeb</a>">WikiWikiWeb</a>when the pattern linker sees the second WikiCase word if the author surrounds it with triple quotes: so[WikiWikiWeb](http://wiki.c2.com/?"""WikiWikiWeb""")is now transformed to<a href="http://wiki.c2.com/?WikiWikiWeb">WikiWikiWeb</a>.The function responsible,
_do_link_patterns(), already checked for the cases that the pattern was inside square brackets, or was preceeded by](or suffixed by"), and skips expanding in these cases. This addition simply adds a check that the pattern is not surrounded by triple quotes; the triple quotes are stripped from the output.