Un-smart-quote footnote back refs #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symroe
force-pushed
the
150-fix-footnote-back-refs
branch
from
dbf847d
to
96349a5
Compare
|
Considering this issue is so long running, a temporary fix might do for now. Can you add a TODO with a link to the issue number before that new Thanks! |
symroe
force-pushed
the
150-fix-footnote-back-refs
branch
from
96349a5
to
c74d041
Compare
|
Sure, added, let me know if you'd rather a more verbose comment |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #150
I don't think this is a great solution to this problem, as clearly attributes in HTML should never be smart-quoted.
However, for this specific problem this patch is a fix.
I'd be happy to chat more about better ways of doing this and to work on a better fix.