Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Remove source code for support legacy Python versions #305

Closed
thombashi opened this issue Sep 22, 2018 · 2 comments
Closed

[Suggestion] Remove source code for support legacy Python versions #305

thombashi opened this issue Sep 22, 2018 · 2 comments

Comments

@thombashi
Copy link
Contributor

In the current repository, I can find source codes for a specific Python version that already dropped supporting (Python 2.3, 2.4, etc.).
I assume that these codes are no longer needed.
Could I possibly create a PR to remove these source code?
It will improve source code readability and maintainability.
@nicholasserra
Copy link
Collaborator

Yes, I think it's fine to remove those. Maybe just keep 2.6 support?

@thombashi
Copy link
Contributor Author

Thank you for your response.
I had make a PR about this issue: #306
In the PR, remain unchanged Python 2.6 / 3.3 support.

Since Python 2.6 and 3.3 is already EOL, these versions also might be okay to drop.

@thombashi thombashi mentioned this issue Sep 24, 2018
Merged
nicholasserra added a commit that referenced this issue Sep 26, 2018
@nicholasserra
Merge pull request #306 from thombashi/drop_legacy_python_support
10ef09d 
Drop support for legacy Python versions: Issue #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicholasserra @thombashi