Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wheel package support: Issue #228 #304

Merged
merged 1 commit into from Oct 10, 2018

Conversation

thombashi
Copy link
Contributor

This PR adds a functionality to make packages for both tar.gz and whl (Wheel format).
For example:

$ python setup.py build
...
$ ls dist
markdown2-2.3.6-py2.py3-none-any.whl  markdown2-2.3.6.tar.gz

You will need to change to specify both packages when uploading packages to PyPI:

twine upload dist/markdown2-2.3.6-py2.py3-none-any.whl dist/markdown2-2.3.6.tar.gz

@nicholasserra
Copy link
Collaborator

Normally doing an sdist upload so i'll have to check into what's needed before I merge this. Thank you

@nicholasserra
Copy link
Collaborator

Finally diving into this. Gotta change how the release upload is happening. Question for ya:

I notice python setup.py build is now also generating some extra files:

/lib/markdown2.egg-info/dependency_links.txt
/lib/markdown2.egg-info/PKG-INFO
/lib/markdown2.egg-info/SOURCES.txt
/lib/markdown2.egg-info/top_level.txt

Should these be ignored? Not sure why they're popping up.

@thombashi
Copy link
Contributor Author

You can ignore those files.
Files under *.egg_info/ are intermediate product generated by setuptools.
Adding *.egg_info/ to .gitignore might be useful.

@nicholasserra nicholasserra merged commit 72f7a0b into trentm:master Oct 10, 2018
@nicholasserra nicholasserra mentioned this pull request Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants