Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing cuddled-lists with a single list item #288

Merged
merged 2 commits into from Apr 8, 2018

Conversation

hmagdy
Copy link
Contributor

@hmagdy hmagdy commented Apr 3, 2018

this hotfix is mainly the resolution of
#286

@hmagdy hmagdy changed the title fix does not work with a single list item fixing cuddled-lists with a single list item Apr 3, 2018
@nicholasserra
Copy link
Collaborator

Hello, thanks for the PR!

In those test changes, was the addition of those tabs just to make the test pass with your changes? if it was a side effect of the patch and unrelated I wouldn't want to introduce a change like that.

Or is that rest change related to your fix?

@hmagdy
Copy link
Contributor Author

hmagdy commented Apr 3, 2018

@nicholasserra the test changes are required and make sense too, as you can see at any markdown editor, the below lines "old lines" (without tabs)

Here is an asterisk,
* What do you think
about it?

I suggest using version
1. Oops, now this line is treated
as a sub-list.

should be marked as bulleted and numeric list like:

Here is an asterisk,

  • What do you think
    about it?

I suggest using version

  1. Oops, now this line is treated
    as a sub-list.

So I think the correct test files are these new files (with tabs)

Here is an asterisk,
    * What do you think
about it?

I suggest using version
    8. Oops, now this line is treated
as a sub-list.

should be marked as none bulleted or numeric list like:

Here is an asterisk,
* What do you think
about it?

I suggest using version
8. Oops, now this line is treated
as a sub-list.


@hmagdy
Copy link
Contributor Author

hmagdy commented Apr 3, 2018

@nicholasserra Added new test cases for the fix. which cover lists with single item.

@nicholasserra nicholasserra merged commit aa8f800 into trentm:master Apr 8, 2018
@nicholasserra
Copy link
Collaborator

Awesome thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants