Skip to content

Fix some pep8 format with flake8 and support new feature. #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 8, 2016

Conversation

keysona
Copy link
Contributor

@keysona keysona commented May 31, 2016

Some block comments:

#---xx

to

# ---xx

And some errors:trailing semicolon in python statement.
Like this:

_bq_one_level_re_spoiler = re.compile('^[ \t]*>[ \t]*?![ \t]?', re.M);

New feature:
A link with "_blank" in target attribute.
For example :

[Ref](http://www.example.com)

To

<p><a target="_blank" href="http://www.example.com">Ref</a></p>

extras option is "link-with-blank".

@keysona
Copy link
Contributor Author

keysona commented May 31, 2016

#213

@keysona keysona changed the title Fix some pep8 format with flake8. Fix some pep8 format with flake8 and support new feature. May 31, 2016
@nicholasserra
Copy link
Collaborator

Thanks!

So the idea here is that when you turn on the link-with-blank extra, any links in markdown will have target="_blank"?

@keysona
Copy link
Contributor Author

keysona commented Jun 4, 2016

@nicholasserra

Yes, like nofollow.

Maybe this extras option name link-with-blank is too long?

I think it can be shortest, maybe blank or _blank?

@nicholasserra
Copy link
Collaborator

Gotcha, cool. I don't think it's too long, but I think it's hard to understand. How about target-blank-links?

@keysona
Copy link
Contributor Author

keysona commented Jun 5, 2016

@nicholasserra
Good name!
I agree to use target-blank-links, it really easy to understand!
Now I change the name:-).

@nicholasserra nicholasserra merged commit 2015691 into trentm:master Jun 8, 2016
@nicholasserra
Copy link
Collaborator

Thanks!

@keysona
Copy link
Contributor Author

keysona commented Jun 8, 2016

#213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants