Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using vlib_log for logging #144

Open
ivan4th opened this issue Jun 17, 2021 · 0 comments
Open

Consider using vlib_log for logging #144

ivan4th opened this issue Jun 17, 2021 · 0 comments

Comments

@ivan4th
Copy link
Contributor

ivan4th commented Jun 17, 2021

Some of the diagnostics that can only be displayed by building UPG with various values of CLIB_DEBUG should be instead done using macros that use vlib_log() under the hood, using debug log level. This way, it will be possible to get extended diagnostics by using set logging class CLI command.

Care should be taken not to affect the performance in some tight loops, though; in these places, the old scheme can be left in place or we might add extra checks for log levels before doing the calls.

We may use several logging classes (charging, forwarding, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant