Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ownable2 step #385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ownable2 step #385

wants to merge 2 commits into from

Conversation

sandybradley
Copy link

Description

Create Ownable2Step

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

closes #375

0xtekgrinder
0xtekgrinder suggested changes Aug 29, 2023
View reviewed changes
Copy link

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I am the creator of the issue linked to this PR. I think it may lacks a constructor to be able to specify easily the original owner of the contract

@sandybradley
Copy link
Author

Thanks for your feedback. The new contract inherits original Owned contract which set owner at construction:

    constructor(address _owner) {
        owner = _owner;

        emit OwnershipTransferred(address(0), _owner);
    }

Let me verify that assertion by adding some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xtekgrinder 0xtekgrinder 0xtekgrinder requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Owned2Step
2 participants
@sandybradley @0xtekgrinder