Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named parameters in mapping types with solidity 0.8.18 #360

Open
cupOJoseph opened this issue Feb 5, 2023 · 2 comments
Open

Add named parameters in mapping types with solidity 0.8.18 #360

cupOJoseph opened this issue Feb 5, 2023 · 2 comments

Comments

@cupOJoseph
Copy link

I'm happy to make the changes if maintainers want to assign me, but it will require updating the contracts to 0.8.18, which may not be ideal at the moment.

Example: ERC20 could be changed to

    /*//////////////////////////////////////////////////////////////
                              ERC20 STORAGE
    //////////////////////////////////////////////////////////////*/

    uint256 public totalSupply;

    mapping(address user => uint256 balance) public balanceOf;

    mapping(address user => mapping(address spender => uint256 allowance)) public allowance;
@transmissions11
Copy link
Owner

I'm happy to make the changes if maintainers want to assign me, but it will require updating the contracts to 0.8.18, which may not be ideal at the moment.

yeahh my thoughts as well... we'll have to make a decision about breaking backwards compatibility soon cuz it seems like 0.9 is a ways away but idt this is the time yet

@cupOJoseph
Copy link
Author

I agree there are benefits for everything to just be <=0.8.0 for now. I'll check in again on this closer to 0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants