Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EIP712 functionality compatible with delegate calls #130

Closed
k06a opened this issue Feb 16, 2022 · 3 comments
Closed

Make EIP712 functionality compatible with delegate calls #130

k06a opened this issue Feb 16, 2022 · 3 comments

Comments

@k06a
Copy link

k06a commented Feb 16, 2022

Consider borrowing the idea from this PR: OpenZeppelin/openzeppelin-contracts#2852

You have to cache the address of the smart contract in immutable to prevent issues when implementation is used via delegate calls.

@transmissions11
Copy link
Owner

would prefer ppl fork, don't want to increase complexity for a use case we don't encourage

@k06a
Copy link
Author

k06a commented Mar 4, 2022

@transmissions11 someone could use your library in this manner and get suffered from this issue. I assume the fix is relatively cheap, just cache address of this in immutable.

@transmissions11
Copy link
Owner

There are plenty of other foot guns, such as the reentrancy guard not being compatible with delegatecall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants