Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/dashboard: Fix low-contrast hover styles #4347

Merged
merged 1 commit into from Mar 7, 2023
Merged

Conversation

nqst
Copy link
Contributor

@nqst nqst commented Mar 7, 2023

After modifying the dashboard background, the icon hover styles became barely visible. Fixing it here:

Before:

Screenshot 07-03-2023 at 11 45 30

After:

Screenshot 07-03-2023 at 11 45 49

Full preview:

Screenshot.07-03-2023.at.11.15.59.mp4

@nqst nqst added UI User Interface issues Dashboard labels Mar 7, 2023
@nqst nqst requested a review from Murderlon March 7, 2023 10:49
@nqst nqst self-assigned this Mar 7, 2023
@Murderlon Murderlon merged commit df32c1c into main Mar 7, 2023
@Murderlon Murderlon deleted the dashboard-fix-hover branch March 7, 2023 11:27
@Murderlon
Copy link
Member

Thanks!

@github-actions github-actions bot mentioned this pull request Mar 7, 2023
github-actions bot added a commit that referenced this pull request Mar 7, 2023
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/core      |   3.1.1 | uppy            |   3.6.1 |
| @uppy/dashboard |   3.3.1 |                 |         |

- @uppy/dashboard: Fix low-contrast hover styles (Alexander Zaytsev / #4347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants