@uppy/dashboard: update provider icon style #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed now since we removed colorful circles behind the service icons
To play better with the new icon style
|
Looking good! Thanks for the quick turnaround again! Not sure about Dropbox: seems out of place in dark mode, as it’s the only white one. I also feel like I might want the margins around icons a bit bigger, meaning bigger background layer under them, like what you’ve shown before:
But I go back and forth on that last one, maybe I just need time to adjust, we can tweak this easily later. |
Murderlon
approved these changes
Mar 6, 2023
arturi
approved these changes
Mar 6, 2023
mifi
approved these changes
Mar 7, 2023
Murderlon
changed the title
Merged
github-actions bot
added a commit
that referenced
this pull request
Mar 7, 2023
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.1.0 | @uppy/onedrive | 3.1.0 | | @uppy/box | 2.1.0 | @uppy/provider-views | 3.1.0 | | @uppy/core | 3.1.0 | @uppy/screen-capture | 3.1.0 | | @uppy/dashboard | 3.3.0 | @uppy/unsplash | 3.1.0 | | @uppy/dropbox | 3.1.0 | @uppy/url | 3.2.0 | | @uppy/facebook | 3.1.0 | @uppy/utils | 5.1.3 | | @uppy/google-drive | 3.1.0 | @uppy/webcam | 3.3.0 | | @uppy/image-editor | 2.1.1 | @uppy/zoom | 2.1.0 | | @uppy/instagram | 3.1.0 | uppy | 3.6.0 | | @uppy/locales | 3.0.7 | | | - @uppy/locales: add missing entries after build (Murderlon) - @uppy/dashboard: update provider icon style (Alexander Zaytsev / #4345) - @uppy/core: fix uppy.resetProgress() (Artur Paikin / #4337) - @uppy/core: fix some types (Antoine du Hamel / #4332) - @uppy/core: Fixed type of State.info to match reality being an array of info objects (Marc Bennewitz / #4321) - @uppy/image-editor: Fix TypeScript error in image-editor types (Matthias Kunnen / #4334) - meta: improve `importFromUploadURLs` docs (Mikael Finstad / #4323) - @uppy/utils: workaround chrome crash (Mikael Finstad / #4310)
This was referenced Mar 7, 2023
This was referenced Mar 15, 2023
This was referenced Mar 28, 2023
aduh95
reviewed
Sep 27, 2023
There was a problem hiding this comment.
what are we doing in this old PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Google now only allows using their full-color Google Drive logo, and doesn't offer any monochrome logo. We can't use the one-color logo any more.
To fix that, I redesigned all the icons, and used the white background for all of them so that we can easily use the new Google Drive logo. Here's how the new version looks:
Dark mode:
Authentication step:
This closes #3153.