Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register_lints shouldn't emit warnings #654

Open
smoelius opened this issue Mar 31, 2023 · 2 comments
Open

register_lints shouldn't emit warnings #654

smoelius opened this issue Mar 31, 2023 · 2 comments

Comments

@smoelius
Copy link
Collaborator

These warnings should be moved to check_crate; they are now emitted when you type cargo dylint list --all:

sess.warn("`non_thread_safe_call_in_test` is unlikely to be effective as `--test` was not passed to rustc");

sess.warn(format!("`overscoped_allow` is disabled: {error:?}"));

We should also probably have a lint for this problem.

@smoelius
Copy link
Collaborator Author

The cited examples were fixed by: 7e6b868

But I am leaving this issue open because it would be nice to have a lint for this problem.

@smoelius
Copy link
Collaborator Author

But I am leaving this issue open because it would be nice to have a lint for this problem.

Maybe this could be solved with disallowed_methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant