New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DummyTqdmFile
line buffering
#960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #960 +/- ##
==========================================
+ Coverage 84.34% 84.42% +0.08%
==========================================
Files 24 24
Lines 1603 1618 +15
Branches 264 265 +1
==========================================
+ Hits 1352 1366 +14
Misses 215 215
- Partials 36 37 +1 |
casperdcl
added
p2-bug-warning ⚠
Visual output bad
to-review 🔍
Awaiting final confirmation
labels
May 28, 2020
casperdcl
reviewed
Oct 26, 2020
casperdcl
approved these changes
Oct 26, 2020
casperdcl
added
to-merge ↰
Imminent
and removed
to-review 🔍
Awaiting final confirmation
labels
Oct 26, 2020
casperdcl
changed the title
Don't insert spurious newlines in DummyTqdmFile.
Oct 26, 2020
DummyTqdmFile
line buffering
anntzer
force-pushed
the
writenl
branch
2 times, most recently
from
February 15, 2021 13:54
285a5d2
to
61d805b
Compare
kindly bumping. |
@anntzer I just made a couple of small fixes - let me know if it works for you. |
casperdcl
added
c1-quick 🕐
Complexity low
p3-enhancement 🔥
Much new such feature
labels
Feb 17, 2021
Seems reasonable to me. |
Only call `tqdm.write` (which inserts a newline) if `DummyTqdmFile.write` is itself called with a string containing a newline; otherwise buffer the rest of the string. See changes in test_tqdm.py for the patterns this allows.
Merged
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c1-quick 🕐
Complexity low
p2-bug-warning ⚠
Visual output bad
p3-enhancement 🔥
Much new such feature
to-merge ↰
Imminent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only call
tqdm.write
(which inserts a newline) ifDummyTqdmFile.write
is itself called with a string containing anewline; otherwise buffer the rest of the string.
See changes in test_tqdm.py for the patterns this allows.
Less important but also useful:
read the known issues
environment, where applicable: