New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas.Panel FutureWarning may become Error #824
Comments
duplicate of #780 really annoying since
|
please reopen if (when) pandas breaks again |
Ah, apologies, I was looking for the FutureWarning in there. Of course, this is clearly the same issue - my bad. |
yes but still going to need reopening at some point in the future. I'm not going to bother divining a decent future-proof wrapper for their messy API and incessant design shifts |
I hate to do this, but I think we need to reopen this issue. I'm seeing this behavior with |
@casperdcl My change removes the warning by removing the Panel functionality. This is inline with usage for |
@dgrahn as |
Hmm... Perhaps an option to "enable panel support".
- Pardon my brevity. I sent this from my phone.
…On Tue, Oct 29, 2019, 3:23 PM Casper da Costa-Luis ***@***.***> wrote:
@dgrahn <https://github.com/dgrahn> as pandas is a soft dependency (tqdm
has no hard deps) this isn't feasible as we can't pin version numbers
anywhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=AADALVJ3R6VKVVILRH5SQ2DQRCEUZA5CNFSM4JCTXRU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRYYMI#issuecomment-547589169>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADALVIZCUIFHFYDM72AA3DQRCEUZANCNFSM4JCTXRUQ>
.
|
I don't use pandas at all, and strongly believe nobody else should, yet I wrote |
How about a default on?
And why the pandas hate?
- Pardon my brevity. I sent this from my phone.
…On Tue, Oct 29, 2019, 5:24 PM Casper da Costa-Luis ***@***.***> wrote:
I don't use pandas at all, and strongly believe nobody else should, yet I
wrote tqdm's wrapper for it in response to community demand. I feel said
community of pandas aficionados expect default "it just works" as opposed
to robust black&whitelisting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=AADALVJLFPAAUGFDAOUG55TQRCSZ5A5CNFSM4JCTXRU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSEGQA#issuecomment-547636032>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADALVJLNYXSB5YP3I42O63QRCSZ5ANCNFSM4JCTXRUQ>
.
|
After 59f457a it'll be default on (as it is now) but also silently not break when they remove the functionality. I know atm |
If there's any pandas core dev who disagrees then I'd be happy to suppress the warning |
So... "I don't like Pandas because they change their API. I want people to see a warning because I don't like Pandas. And I won't include an option to suppress that warning."? I'm also failing to see an issue with dropping support for a deprecated piece of functionality. Release notes could specify to use the functionality, go to an older verison. |
xD definitely not.
I don't like
I think
True, unless convinced otherwise. I believe 1) this will disappear when the functionality is removed (warning will turn into an Import Error which is caught by 59f457a) and 2) I think it's fine to warn about default-on leaving users/devs to wrap code with a simple
This is perhaps true for most software. However, unfortunately, with massively used things (like |
I mean... I was trying to contribute. I offered several solutions and
implemented one of them.
Maybe you'd have better luck if you forked tqdm pandas into its own library?
…On Wed, Oct 30, 2019, 9:46 AM Casper da Costa-Luis ***@***.***> wrote:
xD definitely not.
I don't like Pandas because they change their API
I don't like pandas for many reasons, none of which I am under any
obligation to explain owing to the thankless unfunded open source nature of
my voluntary contributions. My expression of dislike is intended to spur
pandas experts to fight back (ideally using code rather than words).
I want people to see a warning because I don't like Pandas
I think pandas devs would want people to see a warning since tqdm.pandas
is really beta anyway. Nobody's actually checked the code.
And I won't include an option to suppress that warning
True, unless convinced otherwise. I believe 1) this will disappear when
the functionality is removed (warning will turn into an Import Error which
is caught by 59f457a
<59f457a>)
and 2) I think it's fine to warn about default-on leaving users/devs to
wrap code with a simple warnings.filterwarnings if they are happy to
suppress it. Worst case scenario is lots of people wind up reading this
issue and get vaguely perplexed. Better case is they get amused. Best is
they contribute!
I'm also failing to see an issue with dropping support for a deprecated
piece of functionality
This is perhaps true for most software. However, unfortunately, with
massively used things things like python2 and in the words of Joshua Bloch,
APIs are forever.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=AADALVN4GODBBWSO2OKSRATQRGF27A5CNFSM4JCTXRU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECUHI7Q#issuecomment-547910782>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADALVM2S45PAETMWN2YVSTQRGF27ANCNFSM4JCTXRUQ>
.
|
Yes, perhaps. The thing is |
closed by #834 |
I ended up reading this issue and got vaguely perplexed. Also got slightly amused. Unfortunately not contributing. |
FYI #1094 (comment):
Warning will disappear using either |
It looks like
pandas.Panel
is being deprecated:I haven't been able to find any other issues on this, so I figured I'd give you wonderful folks a heads up.
Is it going to be difficult to replace
Panel
?The text was updated successfully, but these errors were encountered: