Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tqdm(disable=None) default, instead of tqdm(disable=False) #1342

Open
5 of 6 tasks
sunyj opened this issue Jul 11, 2022 · 2 comments
Open
5 of 6 tasks

Make tqdm(disable=None) default, instead of tqdm(disable=False) #1342

sunyj opened this issue Jul 11, 2022 · 2 comments

Comments

@sunyj
Copy link

sunyj commented Jul 11, 2022

  • I have marked all applicable categories:
    • documentation request (i.e. "X is missing from the documentation." If instead I want to ask "how to use X?" I understand [StackOverflow#tqdm] is more appropriate)
    • new feature request
  • I have visited the [source website], and in particular
    read the [known issues]
  • I have searched through the [issue tracker] for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:
    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)

From my personal experience (and many others), a progress bar is a great tool in developing but a nightmare for cronjob and logs. It's hard (if not impossible) to find a case in which writing a progress bar to a log file can be justified as good, or even necessary. I think it would be a wise choice to turn tqdm's output off to all non-TTY outputs BY DEFAULT.

@janosh
Copy link

janosh commented Nov 4, 2022

From my personal experience (and many others), a progress bar is a great tool in developing but a nightmare for cronjob and logs. It's hard (if not impossible) to find a case in which writing a progress bar to a log file can be justified as good, or even necessary. I think it would be a wise choice to turn tqdm's output off to all non-TTY outputs BY DEFAULT.

Very much agree with this sentiment. Let's get #1343 merged.

@yifanmai
Copy link

+1 for disable=None by default.

I noticed that this issue and the attached PR are stale. I'd be happy to help get this merged if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants