fix Display wrong epoch on Keras resume training #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #1150 +/- ##
==========================================
- Coverage 89.80% 89.76% -0.05%
==========================================
Files 26 26
Lines 1707 1710 +3
Branches 283 284 +1
==========================================
+ Hits 1533 1535 +2
- Misses 128 129 +1
Partials 46 46 |
casperdcl
reviewed
Mar 19, 2021
tqdm/keras.py
Outdated
Comment on lines
76
to
77
| if self.epoch_bar.n < epoch: | ||
| self.epoch_bar.update(epoch-self.epoch_bar.n) |
There was a problem hiding this comment.
Is this only ever triggered exactly once when training is resumed? Or are there any other circumstances?
There was a problem hiding this comment.
Yes, exactly once. I don't figure out other circumstances.
casperdcl
reviewed
Mar 19, 2021
| @@ -69,10 +69,12 @@ def __init__(self, epochs=None, data_size=None, batch_size=None, verbose=1, | |||
| def on_train_begin(self, *_, **__): | |||
| params = self.params.get | |||
| auto_total = params('epochs', params('nb_epoch', None)) | |||
| if auto_total is not None: | |||
| if auto_total is not None and auto_total != self.epoch_bar.total: | |||
There was a problem hiding this comment.
To avoid re-assigning the total when it is provided manually by the user.
casperdcl
added
p3-enhancement 🔥
casperdcl
force-pushed
the
fix/resumeTrainingKeras
branch
from
f39dcbd
to
3f899b9
Compare
- set initial epochs - update tests
casperdcl
force-pushed
the
fix/resumeTrainingKeras
branch
from
68d91f5
to
74ec622
Compare
casperdcl
added
c1-quick 🕐
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix
TqdmCallbackshowing wrong information about epochs when resume training withinitial_epoch != 0as was reported on #1138The test has been provided but also the Colab example provided by @fabiocarrara here: