Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: support delay #1142

Merged
merged 3 commits into from Apr 5, 2021
Merged

notebook: support delay #1142

merged 3 commits into from Apr 5, 2021

Conversation

peterdhansen
Copy link

If you specify a delay in a jupyter notebook, the bar will always display regardless.

This PR will also delay the display command until the first update, unless display=True.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1142 (8a66f6e) into devel (a162d02) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel    #1142      +/-   ##
==========================================
- Coverage   89.40%   89.08%   -0.32%     
==========================================
  Files          25       25              
  Lines        1651     1658       +7     
  Branches      273      275       +2     
==========================================
+ Hits         1476     1477       +1     
- Misses        129      132       +3     
- Partials       46       49       +3     

@peterdhansen
Copy link
Author

I only see one test for tqdm notebook. I'm not sure how to add a test to cover this new logic.

@casperdcl
Copy link
Sponsor Member

Notebook isn't tested (yet) but I should probably change that soon :)

@casperdcl casperdcl self-assigned this Mar 8, 2021
@casperdcl casperdcl added this to the Non-breaking milestone Mar 8, 2021
@casperdcl casperdcl changed the title fix delay for notebooks notebook: support delay Mar 8, 2021
@casperdcl casperdcl added c1-quick 🕐 Complexity low p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-review 🔍 Awaiting final confirmation labels Mar 8, 2021
@casperdcl casperdcl added to-merge ↰ Imminent and removed to-review 🔍 Awaiting final confirmation labels Mar 17, 2021
@casperdcl casperdcl added this to Next Release in Casper Mar 17, 2021
@casperdcl casperdcl changed the base branch from master to devel April 5, 2021 14:45
@casperdcl
Copy link
Sponsor Member

@peterdhansen I've rebased and added tests, as well as fixed the implementation bugs. Let me know if it works for you now.

@casperdcl casperdcl added c3-small 🕒 Complexity medium and removed c1-quick 🕐 Complexity low labels Apr 5, 2021
@peterdhansen
Copy link
Author

Looks good to me. I tried out the new test notebook and looks like it works as intended

@casperdcl casperdcl merged commit ca11f27 into tqdm:devel Apr 5, 2021
Casper automation moved this from Next Release to Done Apr 5, 2021
@casperdcl casperdcl mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3-small 🕒 Complexity medium p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-merge ↰ Imminent
Projects
Casper
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants