New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook: support delay
#1142
notebook: support delay
#1142
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #1142 +/- ##
==========================================
- Coverage 89.40% 89.08% -0.32%
==========================================
Files 25 25
Lines 1651 1658 +7
Branches 273 275 +2
==========================================
+ Hits 1476 1477 +1
- Misses 129 132 +3
- Partials 46 49 +3 |
I only see one test for tqdm notebook. I'm not sure how to add a test to cover this new logic. |
Notebook isn't tested (yet) but I should probably change that soon :) |
@peterdhansen I've rebased and added tests, as well as fixed the implementation bugs. Let me know if it works for you now. |
Looks good to me. I tried out the new test notebook and looks like it works as intended |
If you specify a delay in a jupyter notebook, the bar will always display regardless.
This PR will also delay the
display
command until the first update, unless display=True.