New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an asyncio.gather() replacement for tqdm #1136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
+ Coverage 84.75% 84.81% +0.06%
==========================================
Files 24 24
Lines 1620 1627 +7
Branches 267 270 +3
==========================================
+ Hits 1373 1380 +7
Misses 209 209
Partials 38 38 |
I'm not too sure how to make this work for older python versions, or whether it's possible, sorry! If someone could point me in the right direction, I might be able to make whatever changes are required |
- reorder imports - fix line length
thanks for this. Made a few changes:
|
Oh that's amazing! I didn't expect that you would fix it all up and neaten it yourself, thank you! |
tqdm's as_completed() is helpful, but does mean results are not in the same order as inputs, which can be frustrating.
I've tried writing a wrapper which emulates the behaviour of asyncio.gather, though I'm not sure whether this conforms to the ideas of the project. (I'm not sure the
typing
import will be well appreciated, at the very least)